Bug 2034484: feat: bumped library-go version#166
Bug 2034484: feat: bumped library-go version#166openshift-merge-robot merged 4 commits intoopenshift:masterfrom
Conversation
|
|
||
| ptpv1 "github.com/openshift/ptp-operator/api/v1" | ||
| "github.com/openshift/ptp-operator/controllers" | ||
| "github.com/openshift/ptp-operator/pkg/leaderelection" |
There was a problem hiding this comment.
Is the leaderelection implementation specific to ptp-operator? Why aren't you just importing https://github.com/openshift/library-go/blob/master/pkg/config/leaderelection/leaderelection.go here?
There was a problem hiding this comment.
Hey @josephdrichard You're right this isn't specific to ptp-operator. When the PR was opened there was a breaking dependency change between the k8s-23 libs and controller-runtime. It was causing some problems and I figured a bit of code was the better approach for now since library-go wasn't being used else where in the code. Luckily, controller-runtime was updated a few hours so we can import it now.
There was a problem hiding this comment.
Are you still looking to update this?
There was a problem hiding this comment.
Apologies, forgot to mention in the reply. This PR has been updated with the latest library-go code and I'm using those methods to drive the leaderelection configs
updated to use latest library-go for leader election - at start up operator will query if it is currently in a SNO or HA topology and set LE Config respective of those environments updated controller-runtime to latest Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
leader_election_config
branch
from
21f19d6 to
57db8c3
Compare
|
Was this tested on a running cluster? |
updated rbac permissions to read infrastructure objects for leader election Signed-off-by: ehila <ehila@redhat.com>
Hey @josephdrichard, for testing this operator I have been relying on the CI cluster to validate that the correct leader election config is being applied. The correct config was applied in there, updated the rbac permissions since I had missed to generate those. |
Signed-off-by: ehila <ehila@redhat.com>
|
/retitle Bug 2034484: feat: bumped library-go version |
openshift-ci
Bot
changed the title
openshift-ci
Bot
added
bugzilla/severity-high
|
@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: ehila <ehila@redhat.com>
|
/retest-required |
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm /approved |
openshift-ci
Bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, josephdrichard The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@eggfoobar: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2034484 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
versionbump 4.22
3 participants
This should take advantage of leader election changes for SNO clusters proposed in this library-go PR.
Changes:
Signed-off-by: ehila ehila@redhat.com